diff options
| author | Florian Vranckx <flvr@odoo.com> | 2025-01-23 13:57:37 +0000 |
|---|---|---|
| committer | Florian Vranckx <flvr@odoo.com> | 2025-01-29 13:43:53 +0000 |
| commit | 9a1bae92bcd8a115fc62d5089cf637b3a9124f0f (patch) | |
| tree | b993346313346ca3eddfa0748ca6c9623bd9a15a /odoo | |
| parent | d7191f31aec0862a0309a99bbc07a2782d35a8b3 (diff) | |
[FIX] test_lint: fix comprehension issue when assigned
this commit add support for comprenhension expression on assign node
add various pylint fixup
closes odoo/odoo#195486
X-original-commit: 7ca897bb97168ac28c6218679aae3aac0c68a5ae
Related: odoo/enterprise#78021
Signed-off-by: Florian Vranckx (flvr) <flvr@odoo.com>
Diffstat (limited to 'odoo')
| -rw-r--r-- | odoo/addons/test_lint/tests/_odoo_checker_sql_injection.py | 5 | ||||
| -rw-r--r-- | odoo/models.py | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/odoo/addons/test_lint/tests/_odoo_checker_sql_injection.py b/odoo/addons/test_lint/tests/_odoo_checker_sql_injection.py index 7c192c0c551..7562d7a8611 100644 --- a/odoo/addons/test_lint/tests/_odoo_checker_sql_injection.py +++ b/odoo/addons/test_lint/tests/_odoo_checker_sql_injection.py @@ -198,7 +198,10 @@ class OdooBaseChecker(BaseChecker): elif isinstance(n.parent, astroid.Module): return True else: - assigned_node += [self._is_constexpr(n.parent.value, args_allowed=args_allowed)] + if isinstance(n.parent, astroid.Comprehension): + assigned_node += [self._is_constexpr(n.parent.iter, args_allowed=args_allowed)] + else: + assigned_node += [self._is_constexpr(n.parent.value, args_allowed=args_allowed)] if assigned_node and all(assigned_node): return True return self._is_asserted(node) diff --git a/odoo/models.py b/odoo/models.py index f349ba2cdff..4e1c08ebdf3 100644 --- a/odoo/models.py +++ b/odoo/models.py @@ -4325,7 +4325,7 @@ class BaseModel(metaclass=MetaModel): for name in regular_fields: corecord = record.sudo()[name] if corecord: - domain = corecord._check_company_domain(companies) + domain = corecord._check_company_domain(companies) # pylint: disable=0601 if domain and not corecord.with_context(active_test=False).filtered_domain(domain): inconsistencies.append((record, name, corecord)) # The second part of the check (for property / company-dependent fields) verifies that the records |