From 55e57a43e08cbe89ffdf8c8bb32cedc7bb74f388 Mon Sep 17 00:00:00 2001 From: hwspeedy Date: Fri, 24 May 2024 12:36:50 +0200 Subject: FIX CodeQL errors - fscanf return value not checked correctly --- modules/computer/uptime.c | 2 +- modules/devices/storage.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/computer/uptime.c b/modules/computer/uptime.c index d12d1c2f..5fc479e9 100644 --- a/modules/computer/uptime.c +++ b/modules/computer/uptime.c @@ -27,7 +27,7 @@ computer_get_uptime(void) if ((procuptime = fopen("/proc/uptime", "r")) != NULL) { int c=fscanf(procuptime, "%lu", &minutes); - if(c) ui->minutes = minutes / 60; + if(c==1) ui->minutes = minutes / 60; fclose(procuptime); } else { g_free(ui); diff --git a/modules/devices/storage.c b/modules/devices/storage.c index e2ba7892..ed6f533f 100644 --- a/modules/devices/storage.c +++ b/modules/devices/storage.c @@ -720,7 +720,7 @@ void __scan_ide_devices(void) if (g_file_test(device, G_FILE_TEST_EXISTS)) { proc_ide = fopen(device, "r"); if (proc_ide) { - if(!fscanf(proc_ide, "%d", &cache)) cache=0; + if(fscanf(proc_ide, "%d", &cache)!=1) cache=0; fclose(proc_ide); } else { cache = 0; -- cgit v1.2.3