summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrancis Dupont <fdupont@isc.org>2022-09-22 18:42:56 +0200
committerFrancis Dupont <fdupont@isc.org>2022-09-23 15:06:06 +0200
commitfb61393bfee72ea0483dd8a912bf8dafd987f42f (patch)
tree1f077c64d531de24610e1fe0455471329f70a3e7
parent9db4418c562f164929a805ba8a70fff9b118d6e3 (diff)
[#1654] Addressed comments, rebasing
-rw-r--r--doc/sphinx/arm/hooks-lease-cmds.rst6
-rw-r--r--src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc3
2 files changed, 7 insertions, 2 deletions
diff --git a/doc/sphinx/arm/hooks-lease-cmds.rst b/doc/sphinx/arm/hooks-lease-cmds.rst
index 98815d5a2d..a818230965 100644
--- a/doc/sphinx/arm/hooks-lease-cmds.rst
+++ b/doc/sphinx/arm/hooks-lease-cmds.rst
@@ -1023,9 +1023,11 @@ backend and write the lease database into a CSV file. They take the path
of the file as the ``filename`` argument. If the specified output file
is the same as the configured memfile one the backend close and reopen
the file in an attempt to synchronize both file and in memory images
-of the lease database.
+of the lease database. The previous file is renamed by appending ``.bak``
+to its name.
.. note::
These commands do not replace the LFC mechanism: they should be used
- only in exceptional circumstances.
+ only in exceptional circumstances, such as when recovering after
+ running out of disk space.
diff --git a/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc b/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc
index a5e276f10a..85b3c8a045 100644
--- a/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc
+++ b/src/hooks/dhcp/lease_cmds/tests/lease_cmds4_unittest.cc
@@ -3139,6 +3139,9 @@ void Lease4CmdsTest::testLease4ConflictingUpdate() {
}
void Lease4CmdsTest::testLease4Write() {
+ // lease4-write negative tests. Positive tests are in the
+ // memfile_lease_mgr_unittest.cc file.
+
// Initialize lease manager (false = v4, false = don't add leases)
initLeaseMgr(false, false);