Test for Perl strict and minimum version

Fix strictness issues across the whole code base, and ensure that
all Perl scripts enable warnings.  (Hopefully enabling warnings
won't cause problems for the server.)

Change-Id: I4dee49f7a6bcbeeee21d74bf61a1fd26514f832c
Reviewed-on: https://gerrit.stanford.edu/1532
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

1 files changed, 24 insertions, 10 deletions

diff --git a/README b/README
index e72bc80..ef910bd 100644
--- a/README
+++ b/README
@@ -118,16 +118,30 @@ REQUIREMENTS
   server.
 
   To run the full test suite, all of the above software requirements must
-  be met.  Tests requiring some bit of software that's not installed
-  should be skipped, but not all the permutations have been checked.  The
-  full test suite also requires the Test::Pod Perl module (available from
-  CPAN), that remctld be installed and available on the user's path or in
-  /usr/local/sbin or /usr/sbin, that sqlite3 be installed and available on
-  the user's path, that test cases can run services on and connect to port
-  14373 on 127.0.0.1, and that kinit and either kvno or kgetcred (which
-  come with Kerberos) be installed and available on the user's path.  The
-  full test suite also requires a local keytab and some additional
-  configuration.
+  be met.  The full test suite also requires that remctld be installed and
+  available on the user's path or in /usr/local/sbin or /usr/sbin, that
+  sqlite3 be installed and available on the user's path, that test cases
+  can run services on and connect to port 14373 on 127.0.0.1, and that
+  kinit and either kvno or kgetcred (which come with Kerberos) be
+  installed and available on the user's path.  The full test suite also
+  requires a local keytab and some additional configuration.
+
+  The following additional Perl modules will be used if present:
+
+      Test::MinimumVersion
+      Test::Pod
+      Test::Spelling
+      Test::Strict
+
+  All are available on CPAN.  Those tests will be skipped if the modules
+  are not available.
+
+  To enable tests that don't detect functionality problems but are used to
+  sanity-check the release, set the environment variable RELEASE_TESTING
+  to a true value.  To enable tests that may be sensitive to the local
+  environment or that produce a lot of false positives without uncovering
+  many problems, set the environment variable AUTHOR_TESTING to a true
+  value.
 
   To bootstrap from a Git checkout, or if you change the Automake files
   and need to regenerate Makefile.in, you will need Automake 1.11 or