Imported Upstream version 2.4.14upstream/2.4.14

1 files changed, 28 insertions, 32 deletions

diff --git a/src/mongo/client/parallel.cpp b/src/mongo/client/parallel.cpp
index 18649d9c6b9..e9dbc644eae 100644
--- a/src/mongo/client/parallel.cpp
+++ b/src/mongo/client/parallel.cpp
@@ -540,14 +540,7 @@ namespace mongo {
         if( full || errored ) retryNext = false;
 
         if( ! retryNext && pcState ){
-
-            if( errored && pcState->conn ){
-                // Don't return this conn to the pool if it's bad
-                pcState->conn->kill();
-                pcState->conn.reset();
-            }
-            else if( initialized ){
-
+            if (initialized && !errored) {
                 verify( pcState->cursor );
                 verify( pcState->conn );
 
@@ -715,26 +708,28 @@ namespace mongo {
         }
 
         const DBClientBase* rawConn = state->conn->getRawConn();
-        if (( _options & QueryOption_SlaveOk ) &&
-                rawConn->type() == ConnectionString::SET &&
-                rawConn->isFailed() ) {
-            /* A side effect of this short circuiting is this will not be
-             * able figure out that the primary is now up on it's own and
-             * has to rely on other threads to refresh the node states.
-             */
+        bool allowShardVersionFailure =
+            rawConn->type() == ConnectionString::SET &&
+            DBClientReplicaSet::isSecondaryQuery( _qSpec.ns(), _qSpec.query(), _qSpec.options() );
+
+        if ( allowShardVersionFailure && rawConn->isFailed() ) {
+
+            state->conn->donotCheckVersion();
+
+            // A side effect of this short circuiting is the mongos will not be able figure out that
+            // the primary is now up on it's own and has to rely on other threads to refresh node
+            // states.
 
             OCCASIONALLY {
-                const DBClientReplicaSet* repl =
-                    dynamic_cast<const DBClientReplicaSet*>( rawConn );
+                const DBClientReplicaSet* repl = dynamic_cast<const DBClientReplicaSet*>( rawConn );
+                dassert(repl);
                 warning() << "Primary for " << repl->getServerAddress()
                           << " was down before, bypassing setShardVersion."
-                          << " Local config view can be stale." << endl;
+                          << " The local replica set view and targeting may be stale." << endl;
             }
-        } else {
+        }
+        else {
             try {
-                /* TODO: Undo SERVER-5797. This try-catch is a temporary hack until
-                 * secondaries can properly handle shard versioning
-                 */
                 if ( state->conn->setVersion() ) {
                     // It's actually okay if we set the version here, since either the
                     // manager will be verified as compatible, or if the manager doesn't
@@ -742,19 +737,20 @@ namespace mongo {
                     LOG( pc ) << "needed to set remote version on connection to value "
                               << "compatible with " << vinfo << endl;
                 }
-            } catch ( const DBException& dbEx ) {
-                if ( (dbEx.getCode() == 10009 /* no master */ &&
-                        ( _options & QueryOption_SlaveOk )) ) {
+            }
+            catch ( const DBException& dbEx ) {
+                if ( allowShardVersionFailure ) {
+
+                    // It's okay if we don't set the version when talking to a secondary, we can
+                    // be stale in any case.
 
                     OCCASIONALLY {
                         const DBClientReplicaSet* repl =
-                            dynamic_cast<const DBClientReplicaSet*>(
-                                    state->conn->getRawConn() );
-
-                        warning() << "Cannot contact primary for "
-                                  << repl->getServerAddress()
-                                  << " to check shard version. "
-                                  << "SlaveOk query can be sent to the wrong shard."
+                            dynamic_cast<const DBClientReplicaSet*>( state->conn->getRawConn() );
+                        dassert(repl);
+                        warning() << "Cannot contact primary for " << repl->getServerAddress()
+                                  << " to check shard version."
+                                  << " The local replica set view and targeting may be stale."
                                   << endl;
                     }
                 }