diff options
| author | Lucas de Castro Borges <lucas@gnuabordo.com.br> | 2025-02-14 14:26:38 -0300 |
|---|---|---|
| committer | Lucas de Castro Borges <lucas@gnuabordo.com.br> | 2025-02-14 14:26:38 -0300 |
| commit | 294bc6ecabf14c09c9bc8644704921dcf97cb44e (patch) | |
| tree | 279b1e0bab53901a1647ac63c1c724f0f789a663 /src/mongo/db/catalog/collection_compact.cpp | |
| parent | 70be7c27a251621187a1de533462ae2bb1e3bd39 (diff) | |
| parent | 1e917fd798aa25b7066d4b414b51184f13d5a092 (diff) | |
Update upstream source from tag 'upstream/6.0.10'debian/6.0.10-1
Update to upstream version '6.0.10'
with Debian dir 2d176fa254eee97b139f712fec5709641335a8c3
Diffstat (limited to 'src/mongo/db/catalog/collection_compact.cpp')
| -rw-r--r-- | src/mongo/db/catalog/collection_compact.cpp | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/mongo/db/catalog/collection_compact.cpp b/src/mongo/db/catalog/collection_compact.cpp index 4fed779eaae..b6cc7cb444d 100644 --- a/src/mongo/db/catalog/collection_compact.cpp +++ b/src/mongo/db/catalog/collection_compact.cpp @@ -74,10 +74,10 @@ StatusWith<int64_t> compactCollection(OperationContext* opCtx, Database* database = autoDb.getDb(); uassert(ErrorCodes::NamespaceNotFound, "database does not exist", database); - // The collection lock will be downgraded to an intent lock if the record store supports - // online compaction. + // The collection lock will be upgraded to an exclusive lock if the record store does not + // support online compaction. boost::optional<Lock::CollectionLock> collLk; - collLk.emplace(opCtx, collectionNss, MODE_X); + collLk.emplace(opCtx, collectionNss, MODE_IX); CollectionPtr collection = getCollectionForCompact(opCtx, collectionNss); DisableDocumentValidation validationDisabler(opCtx); @@ -91,10 +91,9 @@ StatusWith<int64_t> compactCollection(OperationContext* opCtx, str::stream() << "cannot compact collection with record store: " << recordStore->name()); - if (recordStore->supportsOnlineCompaction()) { - // Storage engines that allow online compaction should do so using an intent lock on the - // collection. - collLk.emplace(opCtx, collectionNss, MODE_IX); + if (!recordStore->supportsOnlineCompaction()) { + // Storage engines that disallow online compaction should compact under an exclusive lock. + collLk.emplace(opCtx, collectionNss, MODE_X); // Ensure the collection was not dropped during the re-lock. collection = getCollectionForCompact(opCtx, collectionNss); |
