diff options
author | Russ Allbery <eagle@eyrie.org> | 2020-05-17 17:05:30 -0700 |
---|---|---|
committer | Russ Allbery <eagle@eyrie.org> | 2020-05-17 17:05:30 -0700 |
commit | c138111a3c27863308b6552a5527a9e821a3dc11 (patch) | |
tree | fe3c16462bf0213708f20d251a63e5b9bbf2d23f /tests/data | |
parent | ccfbd34d597318215b979338c4cb5d7e4a3f0d6f (diff) |
Update to rra-c-util 8.2 and C TAP Harness 4.7
Update to rra-c-util 8.2:
* Implement explicit_bzero with memset if it is not available.
* Reformat all C source using clang-format 10.
* Work around Test::Strict not skipping .git directories.
* Fix warnings with perltidy 20190601 and Perl::Critic 1.134.
* Fix warnings with Clang 10, GCC 10, and the Clang static analyzer.
Update to C TAP Harness 4.7:
* Fix warnings with GCC 10.
* Reformat all C source using clang-format 10.
* Fixed malloc error checking in bstrndup.
Diffstat (limited to 'tests/data')
-rw-r--r-- | tests/data/cppcheck.supp | 31 | ||||
-rwxr-xr-x | tests/data/fake-kadmin | 2 |
2 files changed, 29 insertions, 4 deletions
diff --git a/tests/data/cppcheck.supp b/tests/data/cppcheck.supp index 5a421df..442c431 100644 --- a/tests/data/cppcheck.supp +++ b/tests/data/cppcheck.supp @@ -4,7 +4,11 @@ // aren't in rra-c-util, for ease of sharing between projects. The ones that // don't apply to a particular project should hopefully be harmless. // -// Copyright 2018 Russ Allbery <eagle@eyrie.org> +// To determine the correct suppression to add for a new error, run cppcheck +// with the --xml flag and then add a suppression for the error id, file +// location, and line. +// +// Copyright 2018-2020 Russ Allbery <eagle@eyrie.org> // // Copying and distribution of this file, with or without modification, are // permitted in any medium without royalty provided the copyright notice and @@ -17,14 +21,35 @@ // every if and loop body with declarations. variableScope +// strlen of a constant string is more maintainable code than hard-coding the +// string length. +constArgument:tests/runtests.c:804 + // False positive due to recursive function. knownConditionTrueFalse:portable/getopt.c:146 // False positive since the string comes from a command-line define. knownConditionTrueFalse:tests/tap/remctl.c:79 +// Stored in the returned ai struct, but cppcheck can't see the assignment +// because of the struct sockaddr * cast. +memleak:portable/getaddrinfo.c:236 + +// Bug in cppcheck 1.89. The address of this variable is passed to a Windows +// function (albeit through a cast). +nullPointer:portable/winsock.c:61 + // Setting the variable to NULL explicitly after deallocation. redundantAssignment:tests/pam-util/options-t.c -// (remctl) Nested assignments in this test confuse cppcheck. -redundantAssignment:tests/server/acl-t.c +// (remctl) Bug in cppcheck 1.89. The address of these variables are passed +// to a PHP function. +uninitvar:php/php_remctl.c:119 +uninitvar:php/php_remctl.c:123 +uninitvar:php/php_remctl.c:315 +uninitvar:php/php5_remctl.c:125 +uninitvar:php/php5_remctl.c:129 +uninitvar:php/php5_remctl.c:321 + +// (pam-krb5) cppcheck doesn't recognize the unused attribute on labels. +unusedLabel:module/auth.c:895 diff --git a/tests/data/fake-kadmin b/tests/data/fake-kadmin index ff90f88..5fbdc27 100755 --- a/tests/data/fake-kadmin +++ b/tests/data/fake-kadmin @@ -6,7 +6,7 @@ # Copyright 2007, 2014 # The Board of Trustees of the Leland Stanford Junior University # -# See LICENSE for licensing terms. +# SPDX-License-Identifier: MIT use strict; use warnings; |