summaryrefslogtreecommitdiff
path: root/src/mongo/db/catalog/drop_database.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'src/mongo/db/catalog/drop_database.cpp')
-rw-r--r--src/mongo/db/catalog/drop_database.cpp18
1 files changed, 9 insertions, 9 deletions
diff --git a/src/mongo/db/catalog/drop_database.cpp b/src/mongo/db/catalog/drop_database.cpp
index 5e11a71dbfc..85e2087a321 100644
--- a/src/mongo/db/catalog/drop_database.cpp
+++ b/src/mongo/db/catalog/drop_database.cpp
@@ -38,7 +38,7 @@
#include "mongo/db/catalog/database_holder.h"
#include "mongo/db/catalog_raii.h"
#include "mongo/db/client.h"
-#include "mongo/db/concurrency/exception_util.h"
+#include "mongo/db/concurrency/write_conflict_exception.h"
#include "mongo/db/curop.h"
#include "mongo/db/index_builds_coordinator.h"
#include "mongo/db/op_observer.h"
@@ -99,19 +99,17 @@ void _finishDropDatabase(OperationContext* opCtx,
IndexBuildsCoordinator::get(opCtx)->assertNoBgOpInProgForDb(dbName);
}
- // Testing depends on this failpoint stopping execution before the dropDatabase oplog entry is
- // written, as well as before the in-memory state is cleared.
- if (MONGO_unlikely(dropDatabaseHangBeforeInMemoryDrop.shouldFail())) {
- LOGV2(20334, "dropDatabase - fail point dropDatabaseHangBeforeInMemoryDrop enabled");
- dropDatabaseHangBeforeInMemoryDrop.pauseWhileSet();
- }
-
writeConflictRetry(opCtx, "dropDatabase_database", dbName, [&] {
WriteUnitOfWork wunit(opCtx);
opCtx->getServiceContext()->getOpObserver()->onDropDatabase(opCtx, dbName);
wunit.commit();
});
+ if (MONGO_unlikely(dropDatabaseHangBeforeInMemoryDrop.shouldFail())) {
+ LOGV2(20334, "dropDatabase - fail point dropDatabaseHangBeforeInMemoryDrop enabled");
+ dropDatabaseHangBeforeInMemoryDrop.pauseWhileSet();
+ }
+
auto databaseHolder = DatabaseHolder::get(opCtx);
databaseHolder->dropDb(opCtx, db);
dropPendingGuard.dismiss();
@@ -229,7 +227,9 @@ Status _dropDatabase(OperationContext* opCtx, const std::string& dbName, bool ab
std::vector<NamespaceString> collectionsToDrop;
auto catalog = CollectionCatalog::get(opCtx);
- for (auto&& collection : catalog->range(db->name())) {
+ for (auto collIt = catalog->begin(opCtx, db->name()); collIt != catalog->end(opCtx);
+ ++collIt) {
+ auto collection = *collIt;
if (!collection) {
break;
}